[lkml]   [2017]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Check all .c files for bad kernel-doc comments
Hi Matthew,

2017-10-30 22:40 GMT+09:00 Matthew Wilcox <>:
> On Mon, Oct 30, 2017 at 12:40:20PM +0900, Masahiro Yamada wrote:
>> 2017-10-28 4:41 GMT+09:00 Matthew Wilcox <>:
>> > Implement a '-none' output mode for kernel-doc which will only output
>> > warning messages, and suppresses the warning message about there being
>> > no kernel-doc in the file. Add it to the rule to build .o files from .c
>> > files, so it will check all .c files that have been modified.
>> >
>> > Adds about 1300 warnings to my build, but will hopefully discourage
>> > people from introducing more kerneldoc mistakes.
>> Basically, I think this is good,
>> but it is controversial to sprinkle warnings by default.
> Yes, it is. I just got three nastygrams from ;-)
> But if it's not turned on by default, then people aren't going to notice
> when they introduce new warnings.

Some months ago, I annoyed Stephen Rothwell by doing a similar thing:

> I think it needs to be up to someone
> like Andrew or Linus to decide when to add these warnings by default.
> Maybe we should do something like you have below for now, then work on
> cleaning up a few hundred of these warnings, then enable this by default?

Sounds good to me.

If you want to enable it by default now, we need ack from the god. :)

> Thanks for looking at this!
>> Maybe,
>> cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< ;
>> endif
>> so that this is checked only when W=... is given?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to
> More majordomo info at

Best Regards
Masahiro Yamada

 \ /
  Last update: 2017-10-30 16:14    [W:0.071 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site