[lkml]   [2017]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kbuild: fix linker feature test macros when cross compiling with Clang
2017-10-28 3:28 GMT+09:00 Nick Desaulniers <>:
> +
> On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada
> <> wrote:
>> I do not like to add $(CLANG_TARGET) to a place for common helpers.
>> Instead of $(CLANG_TARGET), please add
>> to cc-ldoption and ld-option.
> Thanks for the review. I agree that sounds like a better option.
>> I have two requests next time:
>> - please include in your To list
> Sure thing. scripts/ does not recommend that list for
> this file; is there a way to explicitly add that list to the
> recommendation for that source file?

Ah, I realized MAINTAINERS does not claim the maintainership
of this file.

There are so many misc scripts
in scripts/, so I hesitate to add
scripts/* pattern to MAINTAINERS.

>> - please base your patch on linux-kbuild/kbuild branch
> Will do. Do I need to note it's based off that branch? Otherwise wont
> 0-day bot complain that my patch doesn't apply/build on torvalds/linux
> ?

I am not sure in which case the 0-day bot complain about it.

Now, I applied v2.
If the bot find a problem, it will send us a report.

Best Regards
Masahiro Yamada

 \ /
  Last update: 2017-10-28 20:22    [W:0.116 / U:2.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site