[lkml]   [2017]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort
On Sat, Oct 28 2017 at  2:45:59 pm BST, Dongjiu Geng <> wrote:
> For this matching, switch expression uses fault type which is
> not {I,D}FSC value, but the case expression uses {I,D}FSC,
> they are incompatible. So change the switch expression to
> use {I,D}FSC.

I'm sorry, but I can't manage to parse this commit message. How about
something like this?

"kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but
calls kvm_vcpu_trap_get_fault_type() that only returns the fault class,
thus reducing the scope of the check. This doesn't cause any observable
bug yet as we end-up matching a closely related syndrome for which we
return the same value.

Using kvm_vcpu_trap_get_fault() instead fixes it for good"


Acked-by: Marc Zyngier <>

Jazz is not dead. It just smells funny.

 \ /
  Last update: 2017-10-29 02:13    [W:0.044 / U:10.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site