lkml.org 
[lkml]   [2017]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: generic recovery: check SCL before SDA
On Thu, Oct 05, 2017 at 02:44:14PM +0200, Claudio Foellmi wrote:
> Move the check for a stuck SCL before the check for a high SDA.
> This prevent false positives in the specific case that SDA is fine
> and SCL is stuck, which previously returned 0.
>
> Also check SDA again after the loop, if we can.
> Together, these changes should lead to a lot more failed
> recoveries being caught and returning error codes.
>
> Signed-off-by: Claudio Foellmi <claudio.foellmi@ergon.ch>

Applied to for-next, thanks!

Huh, I thought we already fixed the add-SDA-check-after-loop, but seems
I was wrong :( I am not super happy with the now doubled SDA check, but
refactoring the whole loop is a seperate change IMO which can be done
later.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-10-28 22:56    [W:0.058 / U:6.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site