lkml.org 
[lkml]   [2017]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: can: Use common error handling code in vxcan_newlink()
From
Date
On 10/28/2017 09:18 PM, SF Markus Elfring wrote:
>> If you want to change the semantic of the result check
>
> I am curious if another source code reduction (by the deletion of “ < 0”)
> will become acceptable at similar places.
>

Source code reduction is not the main target.
If you can simplify code without changing the wanted semantic you made
an improvement.

>
>> - this has to done consistently at all rtnl_configure_link() caller sites.
>
> Are there any more functions to consider?

Of course there are more callers of rtnl_configure_link() ...

>> And not only in vxcan.c
>
> Are you interested in related adjustments for a bigger code base?

No. Definitely not.

If you aim for the the deletion of “ < 0” for all rtnl_configure_link()
users you would need to do this consistently.

If you think you would like to do that. Feel free to do it.

Regards,
Oliver

\
 
 \ /
  Last update: 2017-10-28 21:55    [W:0.054 / U:3.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site