lkml.org 
[lkml]   [2017]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/10 v3] usb: usb251xb: Add max power/current dts property support
From
Date
Hi,
again some nit-picks below...

On 10/22/2017 10:38 PM, Serge Semin wrote:
> This parameters may be varied in accordance with hardware specifics.
> So lets add the corresponding settings to the usb251xb driver dts
> specification.
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> ---
> drivers/usb/misc/usb251xb.c | 24 ++++++++++++++++++++----
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index 29432fd3b..669b98be2 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -500,6 +500,26 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
> }
> }
>
> + hub->max_power_sp = USB251XB_DEF_MAX_POWER_SELF;
> + if (!of_property_read_u32(np, "sp-max-total-current-microamp",
> + &property_u32))

Please match the "correct" (of_property_read_u32) opening parenthesis
here...

> + hub->max_power_sp = min_t(u8, property_u32 / 2000, 50);
> +
> + hub->max_power_bp = USB251XB_DEF_MAX_POWER_BUS;
> + if (!of_property_read_u32(np, "bp-max-total-current-microamp",
> + &property_u32))

... and here ...

> + hub->max_power_bp = min_t(u8, property_u32 / 2000, 255);
> +
> + hub->max_current_sp = USB251XB_DEF_MAX_CURRENT_SELF;
> + if (!of_property_read_u32(np, "sp-max-removable-current-microamp",
> + &property_u32))

... and here ...

> + hub->max_current_sp = min_t(u8, property_u32 / 2000, 50);
> +
> + hub->max_current_bp = USB251XB_DEF_MAX_CURRENT_BUS;
> + if (!of_property_read_u32(np, "bp-max-removable-current-microamp",
> + &property_u32))

... and here ...

> + hub->max_current_bp = min_t(u8, property_u32 / 2000, 255);
> +
> hub->power_on_time = USB251XB_DEF_POWER_ON_TIME;
> if (!of_property_read_u32(np, "power-on-time-ms", &property_u32))
> hub->power_on_time = min_t(u8, property_u32 / 2, 255);

Thanks!

kind regards,
Richard.L

\
 
 \ /
  Last update: 2017-10-23 23:55    [W:0.091 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site