lkml.org 
[lkml]   [2017]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi descriptor check
On Thu, Sep 28, 2017 at 7:02 AM, Mario Limonciello
<mario.limonciello@dell.com> wrote:
> Some cases the wrong type was used for errors and checks can be
> done more cleanly.

Oops, I forgot about this patch, so, please, disregard my comment WRT
to strncmp() use to the other patch.


> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> Reviewed-by: Edward O'Callaghan <quasisec@google.com>

Btw, missed Suggested-by?


> - if (desc_buffer[0] != 0x4C4C4544 && desc_buffer[1] != 0x494D5720)
> - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature (%*ph)\n",
> - 8, desc_buffer);
> + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
> + dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature (%8ph)\n",
> + desc_buffer);

And as Darren pointed out, this fixes the logic bug as well.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-10-02 15:16    [W:0.258 / U:1.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site