lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 06/19] s390/zcrypt: register matrix device with VFIO mediated device framework
On Fri, 13 Oct 2017 13:38:51 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:

> diff --git a/drivers/s390/crypto/ap_matrix_bus.c b/drivers/s390/crypto/ap_matrix_bus.c
> index 66bfa54..418c23b 100644
> --- a/drivers/s390/crypto/ap_matrix_bus.c
> +++ b/drivers/s390/crypto/ap_matrix_bus.c
> @@ -61,6 +61,7 @@ static int ap_matrix_dev_create(void)
> matrix->device.bus = &ap_matrix_bus_type;
> matrix->device.parent = ap_matrix_root_device;
> matrix->device.release = ap_matrix_dev_release;
> + INIT_LIST_HEAD(&matrix->queues);
>
> ret = device_register(&matrix->device);
> if (ret) {
> diff --git a/drivers/s390/crypto/ap_matrix_bus.h b/drivers/s390/crypto/ap_matrix_bus.h
> index c2aff23..3eccc36 100644
> --- a/drivers/s390/crypto/ap_matrix_bus.h
> +++ b/drivers/s390/crypto/ap_matrix_bus.h
> @@ -12,8 +12,12 @@
>
> #include <linux/device.h>
>
> +#include "ap_bus.h"
> +
> struct ap_matrix {
> struct device device;
> + spinlock_t qlock;
> + struct list_head queues;
> };
>
> struct ap_matrix *ap_matrix_get_device(void);

Move these two hunks into patch #5 please. Yes, strictly speaking the two elements
in the struct ap_matrix are needed only with patch #6, but it is fine to introduce
an element with a new driver that is only exploited with a later patch.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

\
 
 \ /
  Last update: 2017-10-16 11:05    [W:0.334 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site