lkml.org 
[lkml]   [2017]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] eCryptfs: constify attribute_group structures.
From
Date
Hi Arvind - My apologies for the extremely slow review.

On 06/30/2017 05:33 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6122 636 24 6782 1a7e fs/ecryptfs/main.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6186 604 24 6814 1a9e fs/ecryptfs/main.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

This patch looks good. I'll get it queued up for 4.15.

Tyler

> ---
> fs/ecryptfs/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 9014479..eea4c0f 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj,
> NULL,
> };
>
> -static struct attribute_group attr_group = {
> +static const struct attribute_group attr_group = {
> .attrs = attributes,
> };
>
>


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-10-14 03:30    [W:0.031 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site