lkml.org 
[lkml]   [2017]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] random: remove unused branch in hot code path
On Tue, Dec 27, 2016 at 11:40:23PM +0100, Stephan Müller wrote:
> The variable ip is defined to be a __u64 which is always 8 bytes on any
> architecture. Thus, the check for sizeof(ip) > 4 will always be true.
>
> As the check happens in a hot code path, remove the branch.

The fact that it's a hot code path means the compiler will optimize it
out, so the fact that it's on the hot code path is irrelevant. The
main issue is that on platforms with a 32-bit IP's, ip >> 32 will
always be zero. It might be that we can just do this via

#if BITS_PER_LONG == 32
...
#else
...
#endif

I'm not sure that works for all platforms, though. More research is
needed...

- Ted

\
 
 \ /
  Last update: 2017-01-18 05:36    [W:0.621 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site