[lkml]   [2016]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v5 0/5] firmware: encapsulate firmware loading status
From: Daniel Wagner <>


The firmware user helper code tracks the current state of the loading
process via an member of struct firmware_buf and a completion. Let's
encapsulate this simple state machine into struct fw_status. The aim is
to increase readability and reduce the usage of the fw_lock.

Luis asked by to add a few CC for getting a wider audience. If you
haven't seen this before the initial version of this series has some
more details on the motivation for this series:

I tested this series with and under
kvm and also let it run on real hardware. The series is also available

I had pushed earlier version of series there and haven't got any 0-day
bug reports so far.


This series depends on Luis' "firmware: add SmPL grammar to avoid issues"

changes since v4:
- replaced "firmware: Move umh locking code into fw_load_from_user_helper()"
with "firmware: document user mode helper lock usage"
- changed prefix fw_status_ to fw_umh_
- fixed a couple of bux pointed out by Ming
- changed type of fw_umh::status to u8 and updated commit message to
point out that all states are exclusive

changes since v3:
- added 'firmware: Move umh locking code into
- dropped loading_tiemout and firmware_loading_time() for
- rebased on Luis patches

changes since v2:
- more splitting out
- first patch factors out all the bit ops into fw_status
- second patch gets rid of the bit ops
- third get rid of fw_lock by using swait

changes since v1:
- moved swait change into its own patch
- added ifdef section for FW_LOADER_USER_HELPER_FALLBACK
- updated commit message highlighting the mutex usage drop a bit

Daniel Wagner (5):
firmware: document user mode helper lock usage
firmware: encapsulate firmware loading status
firmware: rename fw_load_from_user_helper() and
firmware: drop bit ops in favor of simple state machine
firmware: do not use fw_lock for fw_umh protection

drivers/base/firmware_class.c | 194 +++++++++++++++++++++++++-----------------
1 file changed, 118 insertions(+), 76 deletions(-)


 \ /
  Last update: 2016-09-17 09:59    [W:0.158 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site