[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.7 013/143] virtio: fix memory leak in virtqueue_add()
4.7-stable review patch.  If anyone has any objections, please let me know.


From: Wei Yongjun <>

commit 58625edf9e2515ed41dac2a24fa8004030a87b87 upstream.

When using the indirect buffers feature, 'desc' is allocated in
virtqueue_add() but isn't freed before leaving on a ring full error,
causing a memory leak.

For example, it seems rather clear that this can trigger
with virtio net if mergeable buffers are not used.

Signed-off-by: Wei Yongjun <>
Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/virtio/virtio_ring.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -316,6 +316,8 @@ static inline int virtqueue_add(struct v
* host should service the ring ASAP. */
if (out_sgs)
+ if (indirect)
+ kfree(desc);
return -ENOSPC;

 \ /
  Last update: 2016-09-17 09:58    [W:0.562 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site