[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.7 093/143] ARC: use correct offset in pt_regs for saving/restoring user mode r25
4.7-stable review patch.  If anyone has any objections, please let me know.


From: Liav Rehana <>

commit 86147e3cfa5e118b61e78f4f0bf29e920dcbd477 upstream.

User mode callee regs are explicitly collected before signal delivery or
breakpoint trap. r25 is special for kernel as it serves as task pointer,
so user mode value is clobbered very early. It is saved in pt_regs where
generally only scratch (aka caller saved) regs are saved.

The code to access the corresponding pt_regs location had a subtle bug as
it was using load/store with scaling of offset, whereas the offset was already
byte wise correct. So fix this by replacing LD.AS with a standard LD

Signed-off-by: Liav Rehana <>
Reviewed-by: Alexey Brodkin <>
[vgupta: rewrote title and commit log]
Signed-off-by: Vineet Gupta <>
Signed-off-by: Greg Kroah-Hartman <>

arch/arc/include/asm/entry.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/arc/include/asm/entry.h
+++ b/arch/arc/include/asm/entry.h
@@ -142,7 +142,7 @@

; Retrieve orig r25 and save it with rest of callee_regs
- r12, [r12, PT_user_r25]
+ ld r12, [r12, PT_user_r25]
PUSH r12
PUSH r25
@@ -198,7 +198,7 @@

; SP is back to start of pt_regs
- r12, [sp, PT_user_r25]
+ st r12, [sp, PT_user_r25]

 \ /
  Last update: 2016-09-17 09:58    [W:0.314 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site