lkml.org 
[lkml]   [2016]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] perf intel-pt-decoder: Report instruction bytes and length in sample
From
Date
On 30/09/16 06:49, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Change the Intel PT decoder to pass up the length and the instruction
> bytes of the decoded or sampled instruction in the perf sample.
>
> The decoder already knows this information, we just need to pass it
> up. Since it is only a couple of movs it is not very expensive.

The decoder doesn't always fill the instruction buffer because it caches the
results from walking basic blocks. That means the bytes from the last
instruction in the basic block would need to be added to the cache.

I wonder if we shouldn't look at something more sophisticated e.g. a python
script that can do full disassembly.

\
 
 \ /
  Last update: 2016-09-30 12:13    [W:0.095 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site