lkml.org 
[lkml]   [2016]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/26] esas2r: constify local structures
    Date
    For structure types defined in the same file or local header files, find
    top-level static structure declarations that have the following
    properties:
    1. Never reassigned.
    2. Address never taken
    3. Not passed to a top-level macro call
    4. No pointer or array-typed field passed to a function or stored in a
    variable.
    Declare structures having all of these properties as const.

    Done using Coccinelle.
    Based on a suggestion by Joe Perches <joe@perches.com>.

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    The semantic patch seems too long for a commit log, but is in the cover
    letter.

    drivers/scsi/esas2r/esas2r_flash.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/esas2r/esas2r_flash.c b/drivers/scsi/esas2r/esas2r_flash.c
    index 7bd376d..f8414b5 100644
    --- a/drivers/scsi/esas2r/esas2r_flash.c
    +++ b/drivers/scsi/esas2r/esas2r_flash.c
    @@ -54,7 +54,7 @@

    #define ESAS2R_FS_DRVR_VER 2

    -static struct esas2r_sas_nvram default_sas_nvram = {
    +static const struct esas2r_sas_nvram default_sas_nvram = {
    { 'E', 'S', 'A', 'S' }, /* signature */
    SASNVR_VERSION, /* version */
    0, /* checksum */
    \
     
     \ /
      Last update: 2016-09-17 09:59    [W:2.187 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site