lkml.org 
[lkml]   [2016]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe
On Fri, Sep 09, 2016 at 11:58:32AM +0300, Mika Westerberg wrote:
> On Fri, Sep 09, 2016 at 04:23:58PM +0800, Phidias Chiang wrote:
> > On Fri, Sep 09, 2016 at 09:18:34AM +0300, Mika Westerberg wrote:
> > > On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote:
> > >
> > > Hmm, how can that happen? The patch removes clearing of INTMASK and only
> > > other place where it is cleared temporarily is on resume. Can you add
> > > dev_info() calls like:
> > >
> > > /* Clear all interrupts */
> > > chv_writel(0xffff, pctrl->regs + CHV_INTSTAT);
> > > dev_info(pctrl->dev, "INTMASK0: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK));
> > >
> > > ...
> > >
> > > gpiochip_set_chained_irqchip(chip, &chv_gpio_irqchip, irq,
> > > chv_gpio_irq_handler);
> > > dev_info(pctrl->dev, "INTMASK1: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK));
> > > return 0;
> > >
> > > It should print the same values both time.
> > >
> > > Also which interrupt does not work and can you send me output of
> > > /proc/interrupts?
> >
> > Output in dmesg:
> > [ 2.054475] cherryview-pinctrl INT33FF:00: INTMASK0: 0x00000006
> > [ 2.055247] cherryview-pinctrl INT33FF:00: INTMASK1: 0x00000000
> > [ 2.055375] cherryview-pinctrl INT33FF:01: INTMASK0: 0x00004000
> > [ 2.056931] cherryview-pinctrl INT33FF:01: INTMASK1: 0x00000000
> > [ 2.057036] cherryview-pinctrl INT33FF:02: INTMASK0: 0x00000000
> > [ 2.057367] cherryview-pinctrl INT33FF:02: INTMASK1: 0x00000000
> > [ 2.057489] cherryview-pinctrl INT33FF:03: INTMASK0: 0x00000000
> > [ 2.058337] cherryview-pinctrl INT33FF:03: INTMASK1: 0x00000000
> >
> > So it's somehow got cleared in the process after.
>
> Only other place where we touch INTMASK register is
> chv_gpio_irq_mask_unmask(). Can you add some debug there to find out the
> caller?

Something like this:

diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 0fe8fad..95fa3b1 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1357,6 +1357,11 @@ static void chv_gpio_irq_mask_unmask(struct irq_data *d, bool mask)
value |= BIT(intr_line);
chv_writel(value, pctrl->regs + CHV_INTMASK);

+ if (printk_ratelimit()) {
+ dev_info(pctrl->dev, "%smask pin %u intmask 0x%08x\n",
+ mask ? "" : "un", pin, readl(pctrl->regs + CHV_INTMASK));
+ }
+
raw_spin_unlock_irqrestore(&chv_lock, flags);
}

\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.083 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site