lkml.org 
[lkml]   [2016]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
Date


> -----Original Message-----
> From: Guenter Roeck [mailto:groeck@google.com]
> Sent: Monday, September 12, 2016 10:24 AM
> To: Jun Li <jun.li@nxp.com>
> Cc: Guenter Roeck <groeck@chromium.org>; Felipe Balbi
> <felipe.balbi@linux.intel.com>; Chandra Sekhar Anagani
> <chandra.sekhar.anagani@intel.com>; Bruce Ashfield
> <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; Pranav Tipnis
> <pranav.tipnis@intel.com>; Heikki Krogerus
> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux-
> usb@vger.kernel.org
> Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
>
> On Sun, Sep 11, 2016 at 7:16 PM, Jun Li <jun.li@nxp.com> wrote:
> > Hi Guenter
> >
> >> -----Original Message-----
> >> From: Guenter Roeck [mailto:groeck@google.com]
> >> Sent: Saturday, September 10, 2016 10:23 AM
> >> To: Jun Li <jun.li@nxp.com>
> >> Cc: Guenter Roeck <groeck@chromium.org>; Felipe Balbi
> >> <felipe.balbi@linux.intel.com>; Chandra Sekhar Anagani
> >> <chandra.sekhar.anagani@intel.com>; Bruce Ashfield
> >> <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>; Pranav
> >> Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus
> >> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org;
> >> linux- usb@vger.kernel.org
> >> Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager
> >> (tcpm)
> >>
> >> On Fri, Sep 9, 2016 at 5:26 PM, Jun Li <jun.li@nxp.com> wrote:
> >> > Hi Guenter,
> >> >
> >> >> -----Original Message-----
> >> >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-
> >> >> owner@vger.kernel.org] On Behalf Of Guenter Roeck
> >> >> Sent: Wednesday, August 24, 2016 5:11 AM
> >> >> To: Felipe Balbi <felipe.balbi@linux.intel.com>
> >> >> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>;
> >> >> Bruce Ashfield <bruce.ashfield@windriver.com>; Bin Gao
> >> >> <bin.gao@intel.com>; Pranav Tipnis <pranav.tipnis@intel.com>;
> >> >> Heikki Krogerus <heikki.krogerus@linux.intel.com>;
> >> >> linux-kernel@vger.kernel.org;
> >> >> linux- usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org>
> >> >> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager
> >> >> (tcpm)
> >> >>
> >> >> This driver implements the USB Type-C Power Delivery state machine
> >> >> for both source and sink ports. Alternate mode support is not
> >> >> fully implemented.
> >> >>
> >> >> The driver attaches to the USB Type-C class code implemented in
> >> >> the following patches.
> >> >>
> >> >> usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C
> PHY
> >> >> usb: USB Type-C connector class
> >> >>
> >> >> This driver only implements the state machine. Lower level drivers
> >> >> are responsible for
> >> >> - Reporting VBUS status and activating VBUS
> >> >> - Setting CC lines and providing CC line status
> >> >> - Setting line polarity
> >> >> - Activating and deactivating VCONN
> >> >> - Setting the current limit
> >> >> - Activating and deactivating PD message transfers
> >> >> - Sending and receiving PD messages
> >> >>
> >> >> The driver provides both a functional API as well as callbacks for
> >> >> lower level drivers.
> >> >>
> >> >> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> >> >> ---
> >> >
> >> > A specific question, if power sink wants to request a new power
> >> > level after SNK_READY, how to handle it with this tcpm?
> >> >
> >>
> >> So far I have considered the required power level to be static, based
> >> on our curent implementations. That should be easy to change, though,
> >> with an additional API function, to be called from a low level driver.
> >> Do you have that requirement, and would such a function meet your
> needs ?
> >>
> >
> > So you are going to make port->tcpc->config to be dynamic to meet my
> need?
> >
> What would that help ? How would tcpm get informed that the power
> requirements changed without an API function telling it that power
> requirements changed ?

Of cos I agree an additional API is required, I am just wondering how
that API will be look like, as current request build is according to
port->tcpc->config.

Li Jun
>
> Guenter
\
 
 \ /
  Last update: 2016-09-17 09:59    [W:0.091 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site