lkml.org 
[lkml]   [2016]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/rockchip: vop: make vop register setting take effect
From
Date
On 2016年08月27日 11:39, Chris Zhong wrote:
> The setting of vop registers need a reg_done writing to take effect.
> In vop_enable the vop return to work by by restoring registers, but the
> registers do not take effect immediately, it should a vop_cfg_done
> after it. The same thing is needed by windows_disabled in
> vop_crtc_disable.
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks for your fix.

applied to my drm-fixes.

> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index efbc41a..a0bfcff 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -464,6 +464,8 @@ static int vop_enable(struct drm_crtc *crtc)
> }
>
> memcpy(vop->regs, vop->regsbak, vop->len);
> + vop_cfg_done(vop);
> +
> /*
> * At here, vop clock & iommu is enable, R/W vop regs would be safe.
> */
> @@ -513,6 +515,8 @@ static void vop_crtc_disable(struct drm_crtc *crtc)
> spin_unlock(&vop->reg_lock);
> }
>
> + vop_cfg_done(vop);
> +
> drm_crtc_vblank_off(crtc);
>
> /*

--
Mark Yao


\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.098 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site