lkml.org 
[lkml]   [2016]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/6] KVM: PPC: e500: Use kmalloc_array() in kvm_vcpu_ioctl_config_tlb()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 28 Aug 2016 16:30:07 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    * Replace the specification of a data type by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/powerpc/kvm/e500_mmu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c
    index 29911a0..26f3737 100644
    --- a/arch/powerpc/kvm/e500_mmu.c
    +++ b/arch/powerpc/kvm/e500_mmu.c
    @@ -779,7 +779,7 @@ int kvm_vcpu_ioctl_config_tlb(struct kvm_vcpu *vcpu,

    num_pages = DIV_ROUND_UP(cfg->array + array_len - 1, PAGE_SIZE) -
    cfg->array / PAGE_SIZE;
    - pages = kmalloc(sizeof(struct page *) * num_pages, GFP_KERNEL);
    + pages = kmalloc_array(num_pages, sizeof(*pages), GFP_KERNEL);
    if (!pages)
    return -ENOMEM;

    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:4.111 / U:2.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site