lkml.org 
[lkml]   [2016]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency
Date
Am Dienstag, 16. August 2016, 09:31:50 schrieb Guenter Roeck:
> On Tue, Aug 16, 2016 at 02:02:00PM +0800, Frank Wang wrote:
> > On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2
> > driver fails to build:
> >
> > drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw'
> > has incomplete type
> >
> > struct clk_hw clk480m_hw;
> >
> > In file included from include/linux/clk.h:16:0
> >
> > from drivers/phy/phy-rockchip-inno-usb2.c:17:
> > include/linux/kernel.h:831:48: error: initialization from incompatible
> > pointer type [-Werror=incompatible-pointer-types]
> >
> > const typeof( ((type *)0)->member ) *__mptr = (ptr); \
> >
> > ... ...
> >
> > Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> > ---
> >
> > drivers/phy/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index f9bf981..c6d57e5 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB
> >
> > config PHY_ROCKCHIP_INNO_USB2
> >
> > tristate "Rockchip INNO USB2PHY Driver"
> > depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
> >
> > + depends on COMMON_CLK
>
> Wonder what is preferred here. I find 33 "select COMMON_CLK" and
> 18 "depends on COMMON_CLK".

In drivers/ I count 12 select COMMON_CLK vs. 37 depends on COMMON_CLK
Do I need new glasses? :-)

With MMC_SDHCI_OF_ARASAN being the only one of all of them we're using on
Rockchip platforms.

I vaguely remember depends being preferred over select in general, so you
don't enable large parts by accident or cause some select chains - but I may
be wrong.


> Either case
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

for me as well:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>


>
> > select GENERIC_PHY
> > help
> >
> > Support for Rockchip USB2.0 PHY with Innosilicon IP block.

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.047 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site