lkml.org 
[lkml]   [2016]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] ARM: Add missing newline terminators to kernel messages
Hi Russell,

On Tue, Aug 16, 2016 at 9:13 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> On Tue, Aug 16, 2016 at 03:40:32PM +0200, Geert Uytterhoeven wrote:
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Before commit 874f9c7da9a4acbc ("printk: create pr_<level> functions"),
>> pr_*() calls without a trailing newline characters would be printed with
>> a newline character appended, both on the console and in the output of
>> the dmesg command.
>>
>> After that commit, no new line character is appended, and the output of
>> the next pr_*() call of the same type may be appended:
>>
>> - Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000
>> - Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)
>> + Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)
>>
>> and:
>>
>> -No ATAGs?
>> -hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
>> +No ATAGs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
>>
>> While this commit has been reverted in commit a0cba2179ea4c182 ("Revert
>> "printk: create pr_<level> functions""), it's still good practice to
>> terminate kernel messages with newlines.
>
> Shouldn't that be above the "---" line?

I didn't put it there because commit 874f9c7da9a4acbc was reverted.

> Other than that, patch looks fine, thanks.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.063 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site