lkml.org 
[lkml]   [2016]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip Technology Co., Ltd
On Tue, Aug 16, 2016 at 07:56:24AM -0500, Rob Herring wrote:
> On Thu, Aug 11, 2016 at 10:11:51PM +0200, Rask Ingemann Lambertsen wrote:
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 1992aa9..fbad2cea 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -256,6 +256,7 @@ ste ST-Ericsson
> > stericsson ST-Ericsson
> > syna Synaptics Inc.
> > synology Synology, Inc.
> > +sunchip Shenzhen Sunchip Technology Co., Ltd
> > SUNW Sun Microsystems, Inc
>
> These are not in alphabetical order. Maybe someone thought uppercase
> should be separate, but I don't. So please fix the ordering here moving
> SUNW before syna.

I'm new to this, so I could use a bit of guidance here. Is it OK if I
send a follow-up patch to fix the ordering or should I send a patch to
fix the ordering first, before the sunchip prefix is added?

I never considered the possibility that the list wouldn't be in
alphabetical order to begin with, so the brain power went into deciding
if uppercase should be sorted separately.

--
Rask Ingemann Lambertsen
Danish law requires addresses in e-mail to be logged and stored for a year

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.048 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site