lkml.org 
[lkml]   [2016]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] ARM: Add missing newline terminators to kernel messages
From
Date
On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote:
> Hi Joe,
>
> On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches <joe@perches.com> wrote:
> >
> > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
> > >
> > > Before commit 874f9c7da9a4acbc ("printk: create pr_<level>
> > > functions"),
> > > pr_*() calls without a trailing newline characters would be
> > > printed with
> > > a newline character appended, both on the console and in the
> > > output of
> > > the dmesg command.
> > Hey Geert.
> >
> > This doesn't apply to -next as the pr_notice/pr_cont below is
> > properly changed to a single pr_notice.
> In which -next?
>
> Not in next-20160816, where the patch applies cleanly.
> Also not in arm/for-next.

My mistake, I was in the wrong directory.
It doesn't apply to Linus' tree.

Still, it'd be slightly nicer to use a single
pr_notice than the pr_notice/pr_cont.

cheers, Joe

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.048 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site