lkml.org 
[lkml]   [2016]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC: callchain showing same entry as hist_entry
Em Wed, Aug 17, 2016 at 12:41:18AM +0900, Namhyung Kim escreveu:
> On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu:
> > > > Did you run 'perf report -s sym --stdio'? It seems that current code
> > > > already works as sane.. Do you want to make it work for the default sort
> > > >> key too?
> > >
> > > What I want is not to repeat the hist_entry line as the first entry in
> > > the callchain, which is confusing.
> > >
> > > I.e. repeat the duplication that is happening with the default sort
> >
> > s/repeat/remove/g
> >
> > > entry, that contains "sym".
>
> Hmm.. if so, wouldn't it be better skipping the first callchain entry
> when the user-given sort key contains "sym" too (not only when it
> starts with 'sym')?

Probably, I think, whatever causes the mentioned duplication. And do
that at all the UIs, hence the suggestion for a callchain__first_node()
or more suitably named routine where such logic would live, to be
used for all the callchain rendering interfaces.

- Arnaldo

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.052 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site