[lkml]   [2016]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRE: [PATCH 3.16 197/305] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing
    Ok No problem.


    Eaton Industries (France) S.A.S ~ Siège social: 110 Rue Blaise Pascal, Immeuble Le Viséo - Bâtiment A Innovallée, 38330, Montbonnot-St.-Martin, France ~ Lieu d'enregistrement au registre du commerce: Grenoble ~ Numéro d'enregistrement: 509 653 176 ~ Capital social souscrit et liberé:€ 16215441 ~ Numéro de TVA: FR47509653176਍

    -----Message d'origine-----
    De : Ben Hutchings []
    Envoyé : samedi 13 août 2016 19:43
    À :;
    Cc :; Roger Quadros; Ocquidant, Sebastien
    Objet : [PATCH 3.16 197/305] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing

    3.16.37-rc1 review patch. If anyone has any objections, please let me know.


    From: "Ocquidant, Sebastien" <>

    commit 8f50b8e57442d28e41bb736c173d8a2490549a82 upstream.

    In the omap gpmc driver it can be noticed that GPMC_CONFIG4_OEEXTRADELAY is overwritten by the WEEXTRADELAY value from the device tree and GPMC_CONFIG4_WEEXTRADELAY is not updated by the value from the device tree.

    As a consequence, the memory accesses cannot be configured properly when the extra delay are needed for OE and WE.

    Fix the update of GPMC_CONFIG4_WEEXTRADELAY with the value from the device tree file and prevents GPMC_CONFIG4_OEXTRADELAY being overwritten by the WEXTRADELAY value from the device tree.

    Signed-off-by: Ocquidant, Sebastien <>
    Signed-off-by: Roger Quadros <>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <>
    arch/arm/mach-omap2/gpmc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/arm/mach-omap2/gpmc.c
    +++ b/arch/arm/mach-omap2/gpmc.c
    @@ -274,7 +274,7 @@ static void gpmc_cs_bool_timings(int cs,
    gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4,
    GPMC_CONFIG4_OEEXTRADELAY, p->oe_extra_delay);
    gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4,
    - GPMC_CONFIG4_OEEXTRADELAY, p->we_extra_delay);
    + GPMC_CONFIG4_WEEXTRADELAY, p->we_extra_delay);
    gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG6,

     \ /
      Last update: 2016-09-17 09:57    [W:4.064 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site