[lkml]   [2016]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints
On Sat, Mar 26, 2016 at 04:50:41PM -0700, Bjorn Andersson wrote:

> Reinstating the following snippet in of_get_regulation_constraints()
> sort this out:

> if (constraints->min_uV && constraints->max_uV)
> constraints->apply_uV = true;

The existing check in the patch should be an || not an ==, or possibly
we should just not bother looking for min_uV at all. I just pushed out
a version of that, let's see how that goes.

> I did look at an alternative of having regulator_set_voltage() pass
> and call set_voltage() if the requested voltage matches the
> constraints, but this does indeed seem to mess things up. So checking
> in with you before continuing on that hack.

Yes, not everything is writeable.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2016-03-27 11:21    [W:0.048 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site