lkml.org 
[lkml]   [2016]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/5] staging: xgifb: fix comparison order
From
Date
On Sun, 2016-03-27 at 15:13 -0400, Clifton Barnes wrote:
> fix checkpatch.pl warning about 'Comparisons should place the constant
> on the right side of the test'

checkpatch false positives.

> Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..8bf253c 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>   if (pVBInfo->LCDInfo & EnableScalingLCD)
>   tempdx &= (~PanelResInfo);
>  
> - if (table[i].PANELID == tempdx) {
> + if (tempdx == table[i].PANELID) {
>   tempbx = table[i].MASK;
>   tempdx = pVBInfo->LCDInfo;
>  
> @@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const
>  
>   i = 0;
>   while (Tap4TimingPtr[i].DE != 0xFFFF) {
> - if (Tap4TimingPtr[i].DE == tempax)
> + if (tempax == Tap4TimingPtr[i].DE)
>   break;
>   i++;
>   }

\
 
 \ /
  Last update: 2016-03-27 22:01    [W:0.055 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site