lkml.org 
[lkml]   [2016]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH v5 2/5] GCC plugin infrastructure
    From
    Hi Emese,



    2016-03-24 9:07 GMT+09:00 Emese Revfy <re.emese@gmail.com>:
    > On Fri, 11 Mar 2016 15:25:19 +0900
    > Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
    >
    >> You sprinkle "gcc-plugins" target in the top Makefile, which I do not like.
    >>
    >> Can you descend into scripts/gcc-plugins from scripts/Makefile?
    >>
    >>
    >> subdir-$(CONFIG_MODVERSIONS) += genksyms
    >> subdir-y += mod
    >> subdir-$(CONFIG_SECURITY_SELINUX) += selinux
    >> subdir-$(CONFIG_DTC) += dtc
    >> subdir-$(CONFIG_GDB_SCRIPTS) += gdb
    >> +subdir-$(CONFIG_GCC_PLUGINS) += gcc-plugins
    >>
    >>
    >> This is how other host tools do, I think.
    >
    > Hi,
    >
    > I tried to remove the gcc-plugins target but sadly in this case the plugins aren't complied.
    > I don't know if I understand how it should work. I pushed a commit:
    > https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/0b005b886bde6c4b9134d01f830d88d464911a65
    > Could you please help me with what I did wrong?
    >


    Sorry, I missed this problem.

    GCC-plugins must be compiled before descending into ./Kbuild.


    Please apply the following on top of commit 0b005b88
    and check if it works.




    diff --git a/Makefile b/Makefile
    index 1c7a379..bd643d3 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -1009,6 +1009,9 @@ archprepare: archheaders archscripts prepare1
    scripts_basic
    prepare0: KBUILD_CFLAGS += $(GCC_PLUGINS_CFLAGS)
    prepare0: KBUILD_AFLAGS += $(GCC_PLUGINS_AFLAGS)
    prepare0: archprepare FORCE
    +ifdef CONFIG_GCC_PLUGINS
    + $(Q)$(MAKE) $(build)=scripts/gcc-plugins
    +endif
    $(Q)$(MAKE) $(build)=.

    # All the preparing..
    diff --git a/scripts/Makefile b/scripts/Makefile
    index 0ba652c..1d80897 100644
    --- a/scripts/Makefile
    +++ b/scripts/Makefile
    @@ -45,7 +45,6 @@ subdir-y += mod
    subdir-$(CONFIG_SECURITY_SELINUX) += selinux
    subdir-$(CONFIG_DTC) += dtc
    subdir-$(CONFIG_GDB_SCRIPTS) += gdb
    -subdir-$(CONFIG_GCC_PLUGINS) += gcc-plugins

    # Let clean descend into subdirs
    -subdir- += basic kconfig package
    +subdir- += basic kconfig package gcc-plugins




    --
    Best Regards
    Masahiro Yamada

    \
     
     \ /
      Last update: 2016-03-26 04:01    [W:2.828 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site