lkml.org 
[lkml]   [2016]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/5] drivers/mtd: make several functions return bool
From
Date
Am 25.03.2016 um 07:31 schrieb Yaowei Bai:
> On Fri, Mar 25, 2016 at 10:54:51AM +0800, Dongsheng Yang wrote:
>> ccing: Brian and Richard
>>
>> Hi Yao,
>> Is that really necessary? I am not sure how much benefit we can
>> achieve from this change.
>> Could you explain more?
>
> Yes, according to these functions' name, a boolean return value is more
> suitable and matchable.
>
> Also personally think this change maybe benfit function's return value
> storage in the stack when called on certain architectures.

On which archs? And what exactly is the benefit?
I agree that bool might be a better choice for new functions
but here you're touching existing and working(!) code.
The only outcome is git history pollution that makes git blame
less efficient.

Thanks,
//richard

\
 
 \ /
  Last update: 2016-03-25 09:21    [W:0.048 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site