Messages in this thread |  | | Subject | Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 | From | Joe Perches <> | Date | Sat, 20 Feb 2016 17:49:16 -0800 |
| |
On Sat, 2016-02-20 at 18:57 -0600, Simon Quigley wrote: > Better?
No, not really.
The alignment should be to the open parenthesis as I wrote in the first reply.
> On 02/20/2016 06:56 PM, Simon Quigley wrote: > > checkpatch.pl reported a warning of over 80 characters on line 1833 > > > > Adjusted to put &extref and &offset on a different line > > > > Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com> > > --- > > fs/btrfs/backref.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c > > index f6dac40..956fffa 100644 > > --- a/fs/btrfs/backref.c > > +++ b/fs/btrfs/backref.c > > @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, > > struct btrfs_root *fs_root, > > unsigned long ptr; > > > > while (1) { > > - ret = btrfs_find_one_extref(fs_root, inum, offset, > > path, &extref, > > - &offset); > > + ret = btrfs_find_one_extref(fs_root, inum, offset, > > path, > > + &extref, > > &offset); > > if (ret < 0) > > break; > > if (ret) { > >
|  |