lkml.org 
[lkml]   [2016]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port
From
Date
On 01/25/2016 06:14 PM, Grygorii Strashko wrote:

>> diff --git a/arch/arm/kernel/entry-common.S
>> b/arch/arm/kernel/entry-common.S
>> index 30a7228eaceb..c3bd6cbfce4b 100644
>> --- a/arch/arm/kernel/entry-common.S
>> +++ b/arch/arm/kernel/entry-common.S
>> @@ -36,7 +36,9 @@
>> UNWIND(.cantunwind )
>> disable_irq_notrace @ disable interrupts
>> ldr r1, [tsk, #TI_FLAGS] @ re-check for syscall tracing
>> - tst r1, #_TIF_SYSCALL_WORK | _TIF_WORK_MASK
>> + tst r1, #((_TIF_SYSCALL_WORK | _TIF_WORK_MASK) & ~_TIF_SECCOMP)
>> + bne fast_work_pending
> ^^^^^^^^^^^^^^^^
>
>> + tst r1, #_TIF_SECCOMP
>> bne fast_work_pending
> ^^^^^^^^^^^^^^^^^
>
> Should it be "fast_work_pending" in both cases?

Yes, I think so and it is, isn't it?
The original is

tst r1, #_TIF_SYSCALL_WORK | _TIF_WORK_MASK
bne fast_work_pending

and with the LAZY bits in it, the ASM opcode no longer works because
the constant is too large (or has to many bits set). So I removed the
_TIF_SECCOMP bit out of the mask and made two compare & jumps here.

Sebastian

\
 
 \ /
  Last update: 2016-02-01 14:41    [W:0.061 / U:2.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site