lkml.org 
[lkml]   [2016]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] inotify: Convert to using per-namespace limits
Nikolay Borisov <n.borisov.lkml@gmail.com> writes:

> On 8.12.2016 03:40, Eric W. Biederman wrote:
>> Nikolay Borisov <kernel@kyup.com> writes:
>>
>>> Gentle ping, now that rc1 has shipped and Jan's sysctl concern hopefully
>>> resolved.
>>
>> After getting slowed down by some fixes I am now taking a hard look at
>> your patch in the hopes of merging it.
>>
>> Did you happen to see the kbuild test roboot boot failures and did you
>> happen to look into what caused them? I have just skimmed them and it
>> appears to be related to your patch.
>
> I saw them in the beginning but they did look like a generic memory
> corruption and I believe at the time those patches were submitted there
> was a lingering memory corruption hitting various patches. Thus I didn't
> think it was related to my patches. I've since left my work so been
> taking a bit of time off and haven't looked really hard, so those
> patches have been kind of lingering.

Fair enough. I generally give the kbuild folks the benefit of the doubt
as they try hard to avoid false positives.

> But now that you mention it I will try and take a second look to see
> what might cause the memory corruption? Is there a way to force 0day to
> re-run them to see whether the failure was indeed caused by my patches
> or were intermittent?

Good question. I will push the patch to my for-testing branch and see
if any problems show up.

That plus I will read through your patch and make certain I can
understand what is going on.

Eric

\
 
 \ /
  Last update: 2016-12-09 03:54    [W:2.646 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site