lkml.org 
[lkml]   [2016]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value
    Date
    On Tue, 2016-12-27 at 22:17:35 +0100, David Dillow wrote:
    >On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
    >> In some cases the return value of a failing function is not being used
    >> and the function typhoon_init_one() returns another negative error
    >> code instead.
    >
    >I'm not sure these changes are especially valuable, since we'll need to
    >look at the dmesg log anyways to figure out what went wrong, but again I
    >don't feel strongly.
    >
    >Fix up the subject issues and I'm happy to ack them.

    As requested, here are the patchsets with the fixed subjects.
    The subjects aswell as the subject prefixes are more precise now.
    Hopefully that's ok.

    Patch 1:
    Makes the function typhoon_init_one() return a negative error code instead of 0.

    Patch 2 [Optional]:
    Makes the function typhoon_init_one() return the return value of the
    corresponding failing function calls instead of a "fixed" negative error code.

    With Regards,
    Milan and Thomas

    \
     
     \ /
      Last update: 2016-12-30 03:38    [W:5.712 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site