Messages in this thread |  | | Date | Tue, 27 Dec 2016 11:52:29 +0200 | From | Sakari Ailus <> | Subject | Re: [PATCH 1/8] [media] v4l2-async: Use kmalloc_array() in v4l2_async_notifier_unregister() |
| |
Thanks!
On Mon, Dec 26, 2016 at 09:43:23PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 26 Dec 2016 18:14:33 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> --- > drivers/media/v4l2-core/v4l2-async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 5bada202b2d3..277183f2d514 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -202,7 +202,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier) > if (!notifier->v4l2_dev) > return; > > - dev = kmalloc(n_subdev * sizeof(*dev), GFP_KERNEL); > + dev = kmalloc_array(n_subdev, sizeof(*dev), GFP_KERNEL); > if (!dev) { > dev_err(notifier->v4l2_dev->dev, > "Failed to allocate device cache!\n");
-- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
|  |