lkml.org 
[lkml]   [2016]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 08/11] mtd: nand: denali: return error code from devm_request_irq() on error
Date
The devm_request_irq() returns an appropriate error value when it
fails. Use it instead of the fixed -ENODEV.

While we are here, reword the comment to make it fit in a single
line, fixing the misspelling of "initialization".

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

drivers/mtd/nand/denali.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index 44e075a..f188a48 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1451,14 +1451,12 @@ int denali_init(struct denali_nand_info *denali)
denali_hw_init(denali);
denali_drv_init(denali);

- /*
- * denali_isr register is done after all the hardware
- * initilization is finished
- */
- if (devm_request_irq(denali->dev, denali->irq, denali_isr, IRQF_SHARED,
- DENALI_NAND_NAME, denali)) {
+ /* request IRQ after all the hardware initialization is finished */
+ ret = devm_request_irq(denali->dev, denali->irq, denali_isr,
+ IRQF_SHARED, DENALI_NAND_NAME, denali);
+ if (ret) {
dev_err(denali->dev, "Unable to request IRQ\n");
- return -ENODEV;
+ return ret;
}

/* now that our ISR is registered, we can enable interrupts */
--
1.9.1
\
 
 \ /
  Last update: 2016-11-09 05:36    [W:0.218 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site