lkml.org 
[lkml]   [2016]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 3/5] mtd: nand: Add bb_per_die and blocks_per_die fields to nand_chip
On Tue, 1 Nov 2016 13:16:28 -0500
Zach Brown <zach.brown@ni.com> wrote:

> The fields bb_per_die and blocks_per_die are useful determining the
> number of bad blocks a MTD needs to allocate. How they are set will
> depend on if the chip is ONFI, JEDEC or a full-id entry in the nand_ids
> table.
>
> Signed-off-by: Zach Brown <zach.brown@ni.com>
> ---
> include/linux/mtd/nand.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index d8905a2..3093827 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -771,6 +771,9 @@ nand_get_sdr_timings(const struct nand_data_interface *conf)
> * supported, 0 otherwise.
> * @jedec_params: [INTERN] holds the JEDEC parameter page when JEDEC is
> * supported, 0 otherwise.
> + * @bb_per_die: [INTERN] the max number of bad blocks each die of a
> + * this nand device will encounter their life times.
> + * @blocks_per_die: [INTERN] The number of PEBs in a die
> * @read_retries: [INTERN] the number of read retry modes supported
> * @onfi_set_features: [REPLACEABLE] set the features for ONFI nand
> * @onfi_get_features: [REPLACEABLE] get the features for ONFI nand
> @@ -853,6 +856,8 @@ struct nand_chip {
> struct nand_onfi_params onfi_params;
> struct nand_jedec_params jedec_params;
> };
> + u16 bb_per_die;

Why not max_bb_per_die?
And please put a single space between the type and the field name.

> + u32 blocks_per_die;
>
> struct nand_data_interface *data_interface;
>

\
 
 \ /
  Last update: 2016-11-06 18:49    [W:0.063 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site