[lkml]   [2016]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 14/17] ASoC: add simple-graph-card document

Hi Mark

> This document really needs quite a bit of fleshing out but I'm not sure
> that should be a blocker for the series as a whole especially given that
> English is not your native language - we can build out later. I think

I'm sorry about my English...

> One thing I'm not 100% clear on here is why it has to be a CPU DAI (I'm
> guessing just one of them though the above says ports as an option?)
> that creates the card? Is there a concrete reason for that or is it
> just being defined as good pracctice?

This explain was not understandable, indeed.

This means, CPU side's port on DT need to have compatible,
and CPU side driver need to call asoc_simple_card_try_to_probe_graph_card()
(= [PATCH 12/17]). asoc_simple_card_try_to_probe_graph_card()
will check this compatible, and probe card driver.
I will fixup and repost v3 after of-graph people's review

compatible = "asoc-simple-graph-card";

 \ /
  Last update: 2016-11-07 04:35    [W:0.044 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site