lkml.org 
[lkml]   [2016]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/14] staging/lustre/ptlrpc: Correctly calculate hrp->hrp_nthrs
On Wed, 2 Nov 2016, Oleg Drokin wrote:

> From: Amir Shehata <amir.shehata@intel.com>
>
> cpu_pattern can specify exactly 1 cpu in a partition:
> "0[0]". That means CPT0 will have CPU 0. CPU 0 can have
> hyperthreading enabled. This combination would result in
>
> weight = cfs_cpu_ht_nsiblings(0);
> hrp->hrp_nthrs = cfs_cpt_weight(ptlrpc_hr.hr_cpt_table, i);
> hrp->hrp_nthrs /= weight;
>
> evaluating to 0. Where
> cfs_cpt_weight(ptlrpc_hr.hr_cpt_table, i) == 1
> weight == 2
>
> Therefore, if hrp_nthrs becomes zero, just set it to 1.

Reviewed-by: James Simmons <jsimmons@infradead.org>

> Signed-off-by: Amir Shehata <amir.shehata@intel.com>
> Reviewed-on: http://review.whamcloud.com/19106
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8492
> Reviewed-by: Liang Zhen <liang.zhen@intel.com>
> Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
> Reviewed-by: James Simmons <uja.ornl@yahoo.com>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> drivers/staging/lustre/lustre/ptlrpc/service.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c b/drivers/staging/lustre/lustre/ptlrpc/service.c
> index 72f3930..fc754e7 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/service.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/service.c
> @@ -2541,8 +2541,9 @@ int ptlrpc_hr_init(void)
>
> hrp->hrp_nthrs = cfs_cpt_weight(ptlrpc_hr.hr_cpt_table, i);
> hrp->hrp_nthrs /= weight;
> + if (hrp->hrp_nthrs == 0)
> + hrp->hrp_nthrs = 1;
>
> - LASSERT(hrp->hrp_nthrs > 0);
> hrp->hrp_thrs =
> kzalloc_node(hrp->hrp_nthrs * sizeof(*hrt), GFP_NOFS,
> cfs_cpt_spread_node(ptlrpc_hr.hr_cpt_table,
> --
> 2.7.4
>
>

\
 
 \ /
  Last update: 2016-11-07 02:58    [W:0.070 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site