lkml.org 
[lkml]   [2016]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field
From
Date
On 11/01/2016 03:02 PM, Christoph Hellwig wrote:
> On Mon, Oct 31, 2016 at 08:37:19PM +0100, Hannes Reinecke wrote:
>> The current LOOP_SET_STATUS64 ioctl has two unused fields
>> 'init[2]', which can be used in conjunction with the
>> LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize.
>
> Can we give them sane field names while at it? Also I see now reason
> not to merge this with the previous two patches.
>
I'd rather not change the name; it's part of the exported ioctl
interface, and changing would mean to change the ioctl interface.
Which would make quite some user-space programs barf.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

\
 
 \ /
  Last update: 2016-11-03 14:26    [W:1.555 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site