lkml.org 
[lkml]   [2016]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace is enabled
Date

> -----Original Message-----
> From: John Stultz [mailto:john.stultz@linaro.org]
> Sent: Tuesday, November 29, 2016 2:39 AM
> To: Chen, Yu C
> Cc: Ingo Molnar; lkml; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown;
> H. Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard
> Cochran
> Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace
> is enabled
>
> On Thu, Nov 24, 2016 at 1:54 AM, Chen, Yu C <yu.c.chen@intel.com> wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of
> >> Ingo Molnar
> >> Sent: Monday, November 21, 2016 4:18 PM
> >> To: John Stultz
> >> Cc: lkml; Chen, Yu C; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown;
> H.
> >> Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard
> >> Cochran
> >> Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if
> >> pm_trace is enabled
> >>
> >>
> >> * John Stultz <john.stultz@linaro.org> wrote:
> >>
> >> > +static int pm_trace_notify(struct notifier_block *nb,
> >> > + unsigned long mode, void *_unused) {
> >> > + switch (mode) {
> >> > + case PM_POST_HIBERNATION:
> >> > + case PM_POST_SUSPEND:
> >> > + if (pm_trace_rtc_abused) {
> >> > + pm_trace_rtc_abused = false;
> >> > + pr_warn("Possible incorrect RTC due to pm_trace,"
> >> > + "please use ntp-date or rdate to
> >> > +reset.\n");
> >>
> >> Please don't break user-visible strings just to pacify checkpatch!
> >>
> >> The bogus linebreak above hides a type in the user string:
> >>
> >> Possible incorrect RTC due to pm_trace,please use ntp-date or rdate to
> reset.
> >>
> >> (There's a missing space after the comma.)
> >>
> >> Best practice is to preserve the continuous nature of the user string in the
> code.
> >>
> >> In addition to that, please quote suggested command names, i.e. something
> like:
> >>
> >> Possible incorrect RTC due to pm_trace, please use 'ntp-date' or
> >> 'rdate' to reset it.
> > OK, will do.
>
> Just a heads up. I've already made these changes in my tree.
>
> thanks
> -john
OK, thanks very much! john.

Yu
\
 
 \ /
  Last update: 2016-11-29 00:47    [W:0.037 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site