lkml.org 
[lkml]   [2016]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 05/33] radix tree test suite: Free preallocated nodes
    Date
    From: Matthew Wilcox <willy@infradead.org>

    It can be a source of mild concern when the test suite shows that we're
    leaking nodes. While poring over the source code looking for leaks
    can lead to some fascinating bugs being discovered, sometimes the leak
    is simply that these nodes were preallocated and are sitting on the
    per-CPU list. Free them by calling the CPU dead callback.

    Signed-off-by: Matthew Wilcox <willy@infradead.org>
    ---
    tools/testing/radix-tree/main.c | 3 +++
    tools/testing/radix-tree/test.h | 1 +
    2 files changed, 4 insertions(+)

    diff --git a/tools/testing/radix-tree/main.c b/tools/testing/radix-tree/main.c
    index 64ffe67..52ce1ea 100644
    --- a/tools/testing/radix-tree/main.c
    +++ b/tools/testing/radix-tree/main.c
    @@ -344,6 +344,9 @@ int main(int argc, char **argv)
    iteration_test();
    single_thread_tests(long_run);

    + /* Free any remaining preallocated nodes */
    + radix_tree_cpu_dead(0);
    +
    sleep(1);
    printf("after sleep(1): %d allocated, preempt %d\n",
    nr_allocated, preempt_count);
    diff --git a/tools/testing/radix-tree/test.h b/tools/testing/radix-tree/test.h
    index 217fb24..5d2fad0 100644
    --- a/tools/testing/radix-tree/test.h
    +++ b/tools/testing/radix-tree/test.h
    @@ -44,3 +44,4 @@ void radix_tree_dump(struct radix_tree_root *root);
    int root_tag_get(struct radix_tree_root *root, unsigned int tag);
    unsigned long node_maxindex(struct radix_tree_node *);
    unsigned long shift_maxindex(unsigned int shift);
    +int radix_tree_cpu_dead(unsigned int cpu);
    --
    2.10.2
    \
     
     \ /
      Last update: 2016-11-28 21:08    [W:4.064 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site