lkml.org 
[lkml]   [2016]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Adding a .platform_init callback to sdhci_arasan_ops
From
Date
+Sai for Xilinx perspective.

On 25.11.2016 16:24, Sebastian Frias wrote:
> Hi,
>
> When using the Arasan SDHCI HW IP, there is a set of parameters called
> "Hardware initialized registers"
>
> (Table 7, Section "Pin Signals", page 56 of Arasan "SD3.0/SDIO3.0/eMMC4.4
> AHB Host Controller", revision 6.0 document)
>
> In some platforms those signals are connected to registers that need to
> be programmed at some point for proper driver/HW initialisation.
>
> I found that the 'struct sdhci_ops' contains a '.platform_init' callback
> that is called from within 'sdhci_pltfm_init', and that seems a good
> candidate for a place to program those registers (*).
>
> Do you agree?
>
> Best regards,
>
> Sebastian
>
>
> (*): This has been prototyped on 4.7 as working properly.
> However, upstream commit:
>
> commit 3ea4666e8d429223fbb39c1dccee7599ef7657d5
> Author: Douglas Anderson <dianders@chromium.org>
> Date: Mon Jun 20 10:56:47 2016 -0700
>
> mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399
> ...
>
> could affect this solution because of the way the 'sdhci_arasan_of_match'
> struct is used after that commit.
>

\
 
 \ /
  Last update: 2016-11-28 08:34    [W:4.314 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site