[lkml]   [2016]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip:x86/cache] x86/intel_rdt: Fix setting of closid when adding CPUs to a group
Commit-ID:  2659f46da8307871989f475accdcdfc4807e9e6c
Author: Fenghua Yu <>
AuthorDate: Fri, 18 Nov 2016 15:18:03 -0800
Committer: Thomas Gleixner <>
CommitDate: Mon, 28 Nov 2016 11:07:50 +0100

x86/intel_rdt: Fix setting of closid when adding CPUs to a group

There was a cut & paste error when adding code to update the per-cpu
closid when changing the bitmask of CPUs to an rdt group.

The update erronously assigns the closid of the default group to the CPUs
which are moved to a group instead of assigning the closid of their new
group. Use the proper closid.

Fixes: f410770293a1 ("x86/intel_rdt: Update percpu closid immeditately on CPUs affected by change")
Signed-off-by: Fenghua Yu <>
Cc: "Ravi V Shankar" <>
Cc: "Tony Luck" <>
Cc: "Sai Prakhya" <>
Cc: "Vikas Shivappa" <>
Cc: "H. Peter Anvin" <>
Signed-off-by: Thomas Gleixner <>

arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index 98edba4..eccea8a 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -278,7 +278,7 @@ static ssize_t rdtgroup_cpus_write(struct kernfs_open_file *of,
cpumask_andnot(&r->cpu_mask, &r->cpu_mask, tmpmask);
- rdt_update_percpu_closid(tmpmask, rdtgroup_default.closid);
+ rdt_update_percpu_closid(tmpmask, rdtgrp->closid);

/* Done pushing/pulling - update this group with new mask */
 \ /
  Last update: 2016-11-28 11:18    [W:0.050 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site