lkml.org 
[lkml]   [2016]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: question about sound/soc/intel/boards/mfld_machine.c
On Mon, Nov 21, 2016 at 07:19:43AM +0530, Jie, Yang wrote:
> > -----Original Message-----
> > From: Julia Lawall [mailto:julia.lawall@lip6.fr]
> > Sent: Sunday, November 20, 2016 1:34 AM
> > To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
> > tiwai@suse.com; Jie, Yang <yang.jie@intel.com>
> > Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org
> > Subject: question about sound/soc/intel/boards/mfld_machine.c
> >
> > Hello,
> >
> > I wonder if the file sound/soc/intel/boards/mfld_machine.c is useful?
> > Until:
> >
> > commit e56c72d5f201044b14191c5b83a25e17f2d68ccf
> > Author: Jie Yang <yang.jie@intel.com>
> > Date: Thu Apr 2 15:37:02 2015 +0800
> >
> > ASoC: Intel: create boards folder and move sst boards files in
> >
> > it was in the directory sound/soc/intel and mentioned in
> > sound/soc/intel/Makefile. The above patch moved it to
> > sound/soc/intel/boards/, but didn't adjust its Makefile entry. The patch:
> >
> > commit b97169da06992ef04081e66ed22bbdb23dbf6610
> > Author: Jie Yang <yang.jie@intel.com>
> > Date: Thu Apr 2 15:37:04 2015 +0800
> >
> > ASoC: Intel: create atom folder and move atom platform files in
> >
> > removed it from sound/soc/intel/Makefile, but didn't move it anywhere.
> > As far as I can tell, there is currently no make information for the file in the
> > kernel.
> >
> > Should the file be dropped?
>
> Thanks for reporting, Julia. I believe this is missed during the folder
> restruction.
>
> Hi Vinod, what do you think? If needed, I can add it to intel/Kconfig.

Yeah looks like a miss. This is also a fact that noone is using this, at
least from upstream, so maybe removing it is not such a bad idea..??

--
~Vinod

\
 
 \ /
  Last update: 2016-11-23 04:33    [W:1.490 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site