lkml.org 
[lkml]   [2016]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/4] block: add scalable completion tracking of requests
On Tue, Nov 01 2016, Johannes Thumshirn wrote:
> On Tue, Nov 01, 2016 at 03:05:22PM -0600, Jens Axboe wrote:
> > For legacy block, we simply track them in the request queue. For
> > blk-mq, we track them on a per-sw queue basis, which we can then
> > sum up through the hardware queues and finally to a per device
> > state.
> >
> > The stats are tracked in, roughly, 0.1s interval windows.
> >
> > Add sysfs files to display the stats.
> >
> > Signed-off-by: Jens Axboe <axboe@fb.com>
> > ---
>
> [...]
>
> >
> > /* incremented at completion time */
> > unsigned long ____cacheline_aligned_in_smp rq_completed[2];
> > + struct blk_rq_stat stat[2];
>
> Can you add an enum or define for the directions? Just 0 and 1 aren't very
> intuitive.

Good point, I added that and updated both the stats patch and the
subsequent blk-mq poll code.

--
Jens Axboe

\
 
 \ /
  Last update: 2016-11-02 06:37    [W:0.330 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site