lkml.org 
[lkml]   [2016]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support
On Wed, Nov 02, 2016 at 01:18:35AM +0000, Kuninori Morimoto wrote:
> + platform = platform_device_register_full(&pdevinfo);
> + if (IS_ERR_OR_NULL(platform))
> + return PTR_ERR(platform);

This is wrong. If platform is NULL, PTR_ERR() will return zero, which
will be interpreted as success. Please, avoid using IS_ERR_OR_NULL(),
it leads to exactly this kind of cockup - and it's unnecessary here
because platform_device_register_full() does not return NULL.

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

\
 
 \ /
  Last update: 2016-11-02 09:29    [W:0.102 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site