lkml.org 
[lkml]   [2016]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86/dumpstack: make stack name tags more comprehensible
2016-11-18 18:46 GMT+01:00 Josh Poimboeuf <jpoimboe@redhat.com>:
> NMI stack dumps are bracked by the following tags:
>
> <NMI>
> ...
> <EOE>
>
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception). The same ending tag is also used to mark the
> end of all other exceptions' stacks. For example:
>
> <#DF>
> ...
> <EOE>
>
> And similarly, "EOI" is used as the ending tag for interrupts:
>
> <IRQ>
> ...
> <EOI>
>
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
>
> <NMI>
> ...
> </NMI>
>
> <#DF>
> ...
> </#DF>
>
> <IRQ>
> ...
> </IRQ>
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

I like that! I hope not too many tools rely on the old namings.
But dmesg isn't supposed to be a stable ABI anyway.

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

\
 
 \ /
  Last update: 2016-11-19 16:50    [W:1.019 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site