[lkml]   [2016]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 00/11] mtd: nand: denali: first round of cleanups of Denali NAND driver
Hi Masahiro,

On Wed, 9 Nov 2016 13:35:19 +0900
Masahiro Yamada <> wrote:

> I am tackling on this driver to use it for my SoCs.
> The difficulty is a bunch of platform specific stuff
> (more specifically, Intel MRST specific) is hard-coded in this driver.
> I need lots of rework to utilize the driver for generic cases,
> but at the same time, I found the driver code is really dirty,
> lots of unused code, odd comments, etc.
> The first thing I needed to do was to clean up the code.
> My work is still under the way, but I decided to drop this series
> for now. I hope this series is easy to review, so I guess
> splitting into a small chunks is better than a one-shot patch bomb.

Well, all I've seen coming from you so far are minor cleanups and
cosmetic changes (including one introducing a regression).
I'll apply this series, but please, next time, try to send the whole
series, so that we can see the big picture, and not just random



> Masahiro Yamada (11):
> mtd: nand: denali: remove unneeded <linux/slab.h> includes
> mtd: nand: denali: remove unused struct member denali_nand_info::idx
> mtd: nand: denali: remove bogus comment about interrupt handler setup
> mtd: nand: denali: remove detect_partition_feature()
> mtd: nand: denali: remove "Spectra:" prefix from printk strings
> mtd: nand: denali: remove unused struct member totalblks, blksperchip
> mtd: nand: denali: use managed devm_irq_request()
> mtd: nand: denali: return error code from devm_request_irq() on error
> mtd: nand: denali: return error code from nand_scan_ident/tail on
> error
> mtd: nand: denali: remove unneeded parentheses
> mtd: nand: denali: remove debug lines of __FILE__, __LINE__, __func__
> drivers/mtd/nand/denali.c | 101 +++++++++---------------------------------
> drivers/mtd/nand/denali.h | 12 -----
> drivers/mtd/nand/denali_dt.c | 1 -
> drivers/mtd/nand/denali_pci.c | 1 -
> 4 files changed, 21 insertions(+), 94 deletions(-)

 \ /
  Last update: 2016-11-19 09:30    [W:0.226 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site