lkml.org 
[lkml]   [2016]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v3 04/20] x86: Handle reduction in physical address size with SME
    From
    Date
    On 11/15/2016 6:14 AM, Borislav Petkov wrote:
    > On Tue, Nov 15, 2016 at 01:10:35PM +0100, Joerg Roedel wrote:
    >> Maybe add a comment here why you can't use cpu_has (yet).
    >
    > So that could be alleviated by moving this function *after*
    > init_scattered_cpuid_features(). Then you can simply do *cpu_has().
    >

    Hmmm... I still need the ebx value from the CPUID instruction to
    calculate the proper reduction in physical bits, so I'll still need
    to make the CPUID call.

    Thanks,
    Tom

    > Also, I'm not sure why we're checking CPUID for the SME feature when we
    > have sme_get_me_mask() et al which have been setup much earlier...
    >

    \
     
     \ /
      Last update: 2016-11-15 22:24    [W:3.833 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site