lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 045/346] batman-adv: Fix speedy join in gateway client mode
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sven Eckelmann <sven@narfation.org>

    commit d1fe176ca51fa3cb35f70c1d876d9a090e9befce upstream.

    Speedy join only works when the received packet is either broadcast or an
    4addr unicast packet. Thus packets converted from broadcast to unicast via
    the gateway handling code have to be converted to 4addr packets to allow
    the receiving gateway server to add the sender address as temporary entry
    to the translation table.

    Not doing it will make the batman-adv gateway server drop the DHCP response
    in many situations because it doesn't yet have the TT entry for the
    destination of the DHCP response.

    Fixes: 371351731e9c ("batman-adv: change interface_rx to get orig node")
    Signed-off-by: Sven Eckelmann <sven@narfation.org>
    Acked-by: Antonio Quartulli <a@unstable.cc>
    Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
    Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/batman-adv/send.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/net/batman-adv/send.c
    +++ b/net/batman-adv/send.c
    @@ -363,8 +363,8 @@ int batadv_send_skb_via_gw(struct batadv
    struct batadv_orig_node *orig_node;

    orig_node = batadv_gw_get_selected_orig(bat_priv);
    - return batadv_send_skb_unicast(bat_priv, skb, BATADV_UNICAST, 0,
    - orig_node, vid);
    + return batadv_send_skb_unicast(bat_priv, skb, BATADV_UNICAST_4ADDR,
    + BATADV_P_DATA, orig_node, vid);
    }

    void batadv_schedule_bat_ogm(struct batadv_hard_iface *hard_iface)
    \
     
     \ /
      Last update: 2016-11-14 05:05    [W:4.030 / U:1.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site